Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cassandra_url handling to be http / https depending on SSL #1221

Merged
merged 2 commits into from
Feb 24, 2024

Conversation

burmanm
Copy link
Contributor

@burmanm burmanm commented Feb 23, 2024

What this PR does:

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@burmanm burmanm requested a review from a team as a code owner February 23, 2024 16:46
Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.32%. Comparing base (018e846) to head (d2cddb9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1221      +/-   ##
==========================================
+ Coverage   57.27%   57.32%   +0.04%     
==========================================
  Files         103      103              
  Lines       10791    10794       +3     
==========================================
+ Hits         6181     6188       +7     
+ Misses       4070     4067       -3     
+ Partials      540      539       -1     
Files Coverage Δ
pkg/medusa/reconcile.go 60.66% <100.00%> (+0.21%) ⬆️

... and 3 files with indirect coverage changes

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Contributor

@adejanovski adejanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested 👍

@adejanovski adejanovski merged commit 524f520 into k8ssandra:main Feb 24, 2024
59 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants