Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If management-api authentication is enabled, mount clientSecret to th… #1215

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

burmanm
Copy link
Contributor

@burmanm burmanm commented Feb 21, 2024

…e medusa container and modify medusa.ini. Update medusa to 0.19.0

What this PR does:

  • Modify medusa container and medusa.ini if management-api requires mTLS connection
  • Update medusa to 0.19.0

Which issue(s) this PR fixes:
Fixes #1214

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@burmanm burmanm requested a review from a team as a code owner February 21, 2024 15:43
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (1b8568f) 57.37% compared to head (d596d09) 57.27%.

❗ Current head d596d09 differs from pull request most recent head d7f60e0. Consider uploading reports for the commit d7f60e0 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1215      +/-   ##
==========================================
- Coverage   57.37%   57.27%   -0.11%     
==========================================
  Files         103      103              
  Lines       10759    10787      +28     
==========================================
+ Hits         6173     6178       +5     
- Misses       4047     4070      +23     
  Partials      539      539              
Files Coverage Δ
pkg/medusa/reconcile.go 60.14% <25.80%> (-2.33%) ⬇️

... and 6 files with indirect coverage changes

@adejanovski adejanovski requested a review from rzvoncek February 22, 2024 08:13
@rzvoncek
Copy link
Contributor

Although, the multi-cluster e2e tests are all over the place.

@rzvoncek
Copy link
Contributor

Made the CI green, will still go and manually test this.

…e medusa container and modify medusa.ini. Update medusa to 0.19.0
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@burmanm burmanm merged commit 6b550d1 into k8ssandra:main Feb 22, 2024
57 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support mounting mgmt-api client certificate for Medusa
2 participants