Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .Values.client.proxy command to allow setting HTTPS_PROXY #1212

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

burmanm
Copy link
Contributor

@burmanm burmanm commented Feb 19, 2024

What this PR does:
Allows easier access to HTTPS_PROXY env variable for CRD upgrader

Which issue(s) this PR fixes:
Fixes #1206

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@burmanm burmanm requested a review from a team as a code owner February 19, 2024 08:30
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad43fce) 57.32% compared to head (480ff03) 57.31%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1212      +/-   ##
==========================================
- Coverage   57.32%   57.31%   -0.01%     
==========================================
  Files         103      103              
  Lines       10715    10715              
==========================================
- Hits         6142     6141       -1     
- Misses       4037     4038       +1     
  Partials      536      536              

see 4 files with indirect coverage changes

@burmanm burmanm merged commit 81ab6bc into k8ssandra:main Feb 20, 2024
59 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose HTTPS_PROXY env variable in CRD upgrader
2 participants