Add new ConcurrencyPolicy setting to the MedusaBackupSchedule #1204
Conversation
…ent multiple active backups working on the same Datacenter
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1204 +/- ##
==========================================
- Coverage 57.31% 57.28% -0.03%
==========================================
Files 103 103
Lines 10680 10709 +29
==========================================
+ Hits 6121 6135 +14
- Misses 4028 4037 +9
- Partials 531 537 +6
|
| return ctrl.Result{}, err | ||
| } else { | ||
| if len(activeTasks) > 0 { | ||
| logger.V(1).Info("Postponing backup schedule due to existing active backups", "MedusaBackupSchedule", req.NamespacedName) |
There was a problem hiding this comment.
[Question]: I've not come across logger.V(1) yet. What does it do?
There was a problem hiding this comment.
It's the same as what in Java you would call for "logger.debug". There's multiple levels (not sure if there's even any limit) of logging you can set, but usually V(1) is for debugging in Go projects and rest are not used.
There was a problem hiding this comment.
[Question] We're adding this (and also the charts/k8ssandra-operator/templates/role.yaml) file. Why did this happen?
There was a problem hiding this comment.
I removed them, from another PR (there's nothing wrong having them here, but they're autogenerated on the release process also, so redundant in here).
|
…ent multiple active backups working on the same Datacenter
What this PR does:
Prevents multiple backup jobs from running concurrently when targeting the same Datacenter. This works with the internal MedusaBackupScheduler and can be disabled using ConcurrencyPolicy Allow.
Which issue(s) this PR fixes:
Fixes #1203
Checklist