-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the MedusaConfiguration API when creating Medusa configuration #1187
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1187 +/- ##
==========================================
+ Coverage 57.13% 57.15% +0.01%
==========================================
Files 103 103
Lines 10618 10647 +29
==========================================
+ Hits 6067 6085 +18
- Misses 4023 4029 +6
- Partials 528 533 +5
|
1edc1c5
to
1b9f17d
Compare
37769ff
to
613facc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor changes and a todo:
We need an e2e test for this.
Modify the single-dc-encryption-medusa
fixture to add a MedusaConfiguration object and modify the K8ssandraCluster storage properties to replace them with the medusaConfigurationRef.
The medusa-bucket-key will be created already (it's at the root of the fixtures
directory) so you just need to reference it in the MedusaConfiguration object.
ab447e3
to
f25a17c
Compare
f25a17c
to
f3a2bed
Compare
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 2 New issues |
What this PR does:
Which issue(s) this PR fixes:
Fixes #1158.
Checklist