Add the ability to configure Reaper with truststore/keystore #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1182 +/- ##
==========================================
+ Coverage 57.19% 57.36% +0.16%
==========================================
Files 101 101
Lines 10529 10554 +25
==========================================
+ Hits 6022 6054 +32
+ Misses 3980 3975 -5
+ Partials 527 525 -2
|
olim7t
approved these changes
Jan 26, 2024
| @@ -378,7 +378,9 @@ type HttpManagement struct { | |||
| // When enabled, HTTP will be used instead of JMX for management connectivity between Cassandra | |||
| // and Reaper. In future, this will be true by default | |||
| // +kubebuilder:default=false | |||
| Enabled *bool `json:"enabled"` | |||
| Enabled bool `json:"enabled,omitempty"` | |||
There was a problem hiding this comment.
[thought] I would be careful changing that, since the comment says it might default to true in the future.
The problem with a raw boolean is that in some case it becomes impossible to differentiate between "unset" and "explicitly set to false".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds keystore and truststore properties and their configuration and mounting to the Reaper Spec
Which issue(s) this PR fixes:
Fixes #1181
Checklist