Add cronjob to purge backups #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1167 +/- ##
==========================================
+ Coverage 57.04% 57.23% +0.18%
==========================================
Files 101 101
Lines 10437 10529 +92
==========================================
+ Hits 5954 6026 +72
- Misses 3962 3977 +15
- Partials 521 526 +5
|
emerkle826
force-pushed
the
k8ssand-1154
branch
2 times, most recently
from
7d1dffa to
64e3c4b
Compare
emerkle826
force-pushed
the
k8ssand-1154
branch
from
525d089 to
d0454f1
Compare
olim7t
requested changes
Jan 18, 2024
| @@ -447,6 +449,10 @@ func MedusaStandaloneDeploymentName(clusterName string, dcName string) string { | |||
| return fmt.Sprintf("%s-%s-medusa-standalone", clusterName, dcName) | |||
| } | |||
|
|
|||
| func MedusaPurgeCronJobName(clusterName string, dcName string) string { | |||
| return fmt.Sprintf("%s-%s-medusa-purge", clusterName, dcName) | |||
There was a problem hiding this comment.
[issue] we should also ensure that the resulting string contains no more than 253 characters.
There was a problem hiding this comment.
I didn't address the length here, rather in the PurgeCronJob function here
There was a problem hiding this comment.
I think we should find a way to truncate rather than failing outright.
|
olim7t
approved these changes
Jan 19, 2024
|
Hello @emerkle826 @olim7t , I have some concerns with this implementation. |
ericsmalling
added a commit
to ericsmalling/k8ssandra-operator
that referenced
this pull request
Apr 11, 2024
This reverts commit 8c32ae3.
ericsmalling
added a commit
to ericsmalling/k8ssandra-operator
that referenced
this pull request
May 22, 2024
This reverts commit 8c32ae3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Creates a CronJob that purges Medusa backups
Which issue(s) this PR fixes:
Fixes #1154
Checklist