Expose Medusas ssl_verify option #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adejanovski
requested changes
Jan 10, 2024
pkg/medusa/reconcile.go
Outdated
Comment on lines
93
to
94
| {{- else }} | ||
| ssl_verify = True |
There was a problem hiding this comment.
Issue: I think the indentation is wrong here.
There was a problem hiding this comment.
Great catch, it looked all good in the IDE.
rzvoncek
force-pushed
the
radovan/ssl-cert-verify
branch
2 times, most recently
from
9067008 to
c848db4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1166 +/- ##
==========================================
- Coverage 56.98% 56.93% -0.05%
==========================================
Files 101 101
Lines 10419 10424 +5
==========================================
- Hits 5937 5935 -2
- Misses 3960 3966 +6
- Partials 522 523 +1
|
adejanovski
approved these changes
Jan 15, 2024
adejanovski
force-pushed
the
radovan/ssl-cert-verify
branch
from
3230ab3 to
08094d7
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds support of Medusa's ssl_verify option.
Which issue(s) this PR fixes:
Fixes #1165
Checklist