Add cluster label to Medusa controllers selectors when listing pods #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adejanovski
force-pushed
the
fix-backup-job-cluster-mismatch
branch
from
19a4cbd to
0755b57
Compare
adejanovski
commented
Dec 20, 2023
Comment on lines
+1
to
+17
| apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| name: cluster2-medusa | ||
| data: | ||
| password: MjdrdU5adHQ3Q1YxYjJCWlZuN2c= | ||
| username: Y2x1c3RlcjItbWVkdXNh | ||
| type: Opaque | ||
| --- | ||
| apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| name: cluster2-superuser | ||
| data: | ||
| password: dGVzdGVycw== | ||
| username: dGVzdDJAdGVzdC5jb20= | ||
| type: Opaque |
There was a problem hiding this comment.
I had to create those secrets because using default secrets seems to create a race condition where they will be deleted upon deletion of the K8ssandraCluster objects before the cassdc objects are deleted, but then cass-operator complains that the secrets are missing and cannot run its finalizers.
burmanm
approved these changes
Dec 20, 2023
adejanovski
force-pushed
the
fix-backup-job-cluster-mismatch
branch
from
aab13fd to
9dfef68
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Properly filters Cassandra pods using both the cluster and dc labels.
Which issue(s) this PR fixes:
Fixes #1132
Checklist