Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Medusa backup size #1123

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Expose Medusa backup size #1123

merged 1 commit into from
Nov 30, 2023

Conversation

rzvoncek
Copy link
Contributor

@rzvoncek rzvoncek commented Nov 29, 2023 •
edited
Loading

What this PR does:

Which issue(s) this PR fixes:
Fixes #1122 .

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@rzvoncek rzvoncek force-pushed the radovan/backup-size-in-summary branch from 0f95c93 to 7e71185 Compare November 29, 2023 16:35
@codecov Codecov
Copy link

codecov bot commented Nov 30, 2023 •
edited
Loading

Codecov Report

Merging #1123 (8aec328) into main (be45e84) will decrease coverage by 0.53%.
The diff coverage is 6.54%.

❗ Current head 8aec328 differs from pull request most recent head 08f9ecd. Consider uploading reports for the commit 08f9ecd to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1123      +/-   ##
==========================================
- Coverage   57.34%   56.81%   -0.53%     
==========================================
  Files         100      100              
  Lines       10193    10300     +107     
==========================================
+ Hits         5845     5852       +7     
- Misses       3836     3935      +99     
- Partials      512      513       +1
Files Coverage Δ
apis/medusa/v1alpha1/medusabackup_types.go 100.00% <ø> (ø)
controllers/medusa/medusabackupjob_controller.go 56.52% <100.00%> (+1.97%) ⬆️
pkg/medusa/reconcile.go 56.62% <ø> (ø)
pkg/medusa/medusa_grpc.pb.go 0.00% <0.00%> (ø)
pkg/medusa/medusa.pb.go 2.84% <0.84%> (-0.31%) ⬇️

... and 1 file with indirect coverage changes

@rzvoncek rzvoncek force-pushed the radovan/backup-size-in-summary branch from 7e71185 to 5c3f373 Compare November 30, 2023 10:18
@rzvoncek rzvoncek mentioned this pull request Nov 30, 2023
Merged
@rzvoncek rzvoncek force-pushed the radovan/backup-size-in-summary branch from 5c3f373 to 8aec328 Compare November 30, 2023 12:43
@rzvoncek rzvoncek force-pushed the radovan/backup-size-in-summary branch from 8aec328 to 08f9ecd Compare November 30, 2023 13:42
@rzvoncek rzvoncek marked this pull request as ready for review November 30, 2023 13:42
@rzvoncek rzvoncek requested a review from a team as a code owner November 30, 2023 13:42
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

adejanovski
adejanovski approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@adejanovski adejanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending passing CI 👍

@rzvoncek rzvoncek merged commit 02d4415 into main Nov 30, 2023
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adejanovski adejanovski adejanovski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose backup size in MedusaBackup CRD
2 participants
@rzvoncek @adejanovski