Fix the namespace relabelling for metrics in Vector #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adejanovski
force-pushed
the
fix/fix-namespace-label-metrics
branch
from
e3fbbf5 to
a8eebf5
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
burmanm
approved these changes
Oct 24, 2023
Codecov Report
@@ Coverage Diff @@
## main #1101 +/- ##
==========================================
- Coverage 57.39% 57.37% -0.02%
==========================================
Files 100 100
Lines 10192 10192
==========================================
- Hits 5850 5848 -2
- Misses 3832 3833 +1
- Partials 510 511 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
The remap was wrongfully setting
.namespaceinstead of.tags.namespacein Vector's configuration. This led the metrics to be prefixed with the namespace instead of being labelled with it.This PR fixes it:
Checklist