Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gRPC max recv size to 256MB #1100

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

burmanm
Copy link
Contributor

@burmanm burmanm commented Oct 24, 2023

What this PR does:
Temporary fix for the Medusa gRPC receiver side (to List backups) by increasing the maximum receive size. This might require increasing the available memory of the k8ssandra-operator, as the request replies can be bigger than the default maximum memory.

Which issue(s) this PR fixes:
Fixes #1102

(not really, it helps with 1102 issue, but our bot wants to close one ticket, so we need to reopen it after merging this PR or it complains).

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@burmanm burmanm requested a review from a team as a code owner October 24, 2023 05:19
Copy link
Contributor

@adejanovski adejanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo: could you add a CHANGELOG entry?

@burmanm
Copy link
Contributor Author

burmanm commented Oct 24, 2023

Todo: could you add a CHANGELOG entry?

We need to make some changes on the Reaper side also, otherwise this will have no effect.

@adejanovski
Copy link
Contributor

Todo: could you add a CHANGELOG entry?

We need to make some changes on the Reaper side also, otherwise this will have no effect.

Could you create a ticket in the Medusa project explaining what changes need to be done?

@burmanm burmanm force-pushed the update_grpc_recv_size branch from 281f0e3 to d1106c9 Compare October 25, 2023 12:11
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.8% 5.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #1100 (d1106c9) into main (f972b64) will increase coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1100      +/-   ##
==========================================
+ Coverage   57.34%   57.44%   +0.09%     
==========================================
  Files         100      100              
  Lines       10193    10193              
==========================================
+ Hits         5845     5855      +10     
+ Misses       3836     3829       -7     
+ Partials      512      509       -3     
Files Coverage Δ
pkg/medusa/grpc.go 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

@adejanovski adejanovski merged commit 32acc8c into k8ssandra:main Oct 25, 2023
58 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing to list Medusa backups if there are too many of them
2 participants