Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for Reaper HTTP management proxy when used with Stargate #1099

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

Miles-Garnsey
Copy link
Member

What this PR does:

Adds a test for the use of Stargate with the Reaper HTTP management proxy.

Which issue(s) this PR fixes:

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@Miles-Garnsey Miles-Garnsey requested a review from a team as a code owner October 23, 2023 14:32
@github-actions
Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@Miles-Garnsey Miles-Garnsey force-pushed the feature/stargate-reaper-http branch from 190e395 to 815e2a7 Compare October 23, 2023 14:36
Copy link
Contributor

@emerkle826 emerkle826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Just waiting on the tests to finish.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #1099 (92eb474) into main (7725008) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1099      +/-   ##
==========================================
- Coverage   57.37%   57.34%   -0.03%     
==========================================
  Files         100      100              
  Lines       10193    10193              
==========================================
- Hits         5848     5845       -3     
- Misses       3834     3836       +2     
- Partials      511      512       +1     

see 1 file with indirect coverage changes

@adejanovski adejanovski force-pushed the feature/stargate-reaper-http branch from 31f7313 to 92eb474 Compare October 26, 2023 06:25
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adejanovski adejanovski merged commit 338b863 into main Oct 26, 2023
58 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants