Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MedusaRestoreJob properly match nodes when restoring in-place #1076

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

rzvoncek
Copy link
Contributor

@rzvoncek rzvoncek commented Oct 3, 2023

What this PR does:
This PR adds a sorting of nodes in a given rack when working out a mapping of nodes to create a restore job. This way it's deterministic and we don't end up mappng nodes 1-2-3 to 1-3-2 etc.

Which issue(s) this PR fixes:
Fixes #1060 .

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #1076 (22f6a6d) into main (31fb6cd) will decrease coverage by 0.06%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1076      +/-   ##
==========================================
- Coverage   57.31%   57.26%   -0.06%     
==========================================
  Files         100      100              
  Lines       10160    10162       +2     
==========================================
- Hits         5823     5819       -4     
- Misses       3828     3832       +4     
- Partials      509      511       +2     
Files Coverage Δ
pkg/medusa/hostmap.go 54.16% <100.00%> (+0.55%) ⬆️

... and 2 files with indirect coverage changes

@rzvoncek rzvoncek marked this pull request as ready for review October 3, 2023 13:29
@rzvoncek rzvoncek requested a review from a team as a code owner October 3, 2023 13:29
@adejanovski adejanovski merged commit 3bbdd74 into main Oct 3, 2023
57 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore mapping seems to shuffle the pods during in place restores
2 participants