Add medusa validation #1054

burmanm · 2023-09-18T14:46:39Z

What this PR does:
Adds validation to MedusaRestoreJob controller that verifies the targetted MedusaBackup can be used to safely restore the target CassandraDatacenter

Which issue(s) this PR fixes:
Fixes #1045

Checklist

Changes manually tested
Automated Tests added/updated
Documentation added/updated
CHANGELOG.md updated (not required for documentation PRs)
CLA Signed: DataStax CLA

codecov · 2023-09-18T14:57:51Z

Codecov Report

Merging #1054 (2e6e29b) into main (580f2d2) will increase coverage by 0.09%.
Report is 1 commits behind head on main.
The diff coverage is 60.78%.

@@            Coverage Diff             @@
##             main    #1054      +/-   ##
==========================================
+ Coverage   57.27%   57.37%   +0.09%     
==========================================
  Files         100      100              
  Lines       10109    10160      +51     
==========================================
+ Hits         5790     5829      +39     
- Misses       3815     3823       +8     
- Partials      504      508       +4

Files Changed	Coverage Δ
apis/medusa/v1alpha1/medusarestorejob_types.go	`100.00% <ø> (ø)`
controllers/medusa/medusarestorejob_controller.go	`57.33% <60.78%> (+0.72%)`	⬆️

... and 3 files with indirect coverage changes

adejanovski

Awesome stuff, I would just like one tiny change to avoid breaking restores of backups created before we modified the MedusaBackup CRD.

adejanovski · 2023-09-19T12:37:33Z

apis/medusa/v1alpha1/medusarestorejob_types.go

@@ -54,6 +54,9 @@ type MedusaRestoreJobStatus struct {
 	Finished []string `json:"finished,omitempty"`

 	Failed []string `json:"failed,omitempty"`
+
+	// Message gives the reason why restore operation failed
+	Message string `json:"message,omitempty"`


suggestion: putting StartTime, FinishTime and Message as printcolumns would be a nice addition. Can do that in a subsequent ticket.

adejanovski · 2023-09-19T12:55:51Z

controllers/medusa/medusarestorejob_controller.go

+		return fmt.Errorf("target backup has not completed successfully")
+	}
+
+	if backup.Status.TotalNodes != cassdc.Spec.Size {


issue: This would break for all backups that were created prior to the new fields being added in the MedusaBackup CRD, right?
Maybe we should detect that and skip validation in this case?
I guess that if backup.Status.TotalNodes = backup.Status.FinishedNodes == 0 then we can skip the validation.