Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AsyncBackup to create the backups #1049

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

burmanm
Copy link
Contributor

@burmanm burmanm commented Sep 14, 2023

What this PR does:
During reconcile, use BackupStatus to check the Status of the Backup and move on only once it has been completed on every node.

This also ensures the backup completion is correctly logged in the objects, even if timeout occurs during the status callbacks or the operator restarts.

Which issue(s) this PR fixes:
Fixes #633

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

… During reconcile, use BackupStatus to check the Status of the Backup and move on only once it has been completed on every node.
@burmanm burmanm requested a review from a team as a code owner September 14, 2023 10:45
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.7% 5.7% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #1049 (ff05b2d) into main (8614857) will decrease coverage by 0.15%.
The diff coverage is 33.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1049      +/-   ##
==========================================
- Coverage   57.43%   57.28%   -0.15%     
==========================================
  Files         100      100              
  Lines       10045    10066      +21     
==========================================
- Hits         5769     5766       -3     
- Misses       3783     3798      +15     
- Partials      493      502       +9     
Files Changed Coverage Δ
pkg/medusa/grpc.go 0.00% <0.00%> (ø)
pkg/medusa/medusa.pb.go 3.14% <ø> (ø)
pkg/medusa/medusa_grpc.pb.go 0.00% <0.00%> (ø)
controllers/medusa/medusabackupjob_controller.go 52.10% <45.00%> (-6.04%) ⬇️

... and 3 files with indirect coverage changes

@adejanovski adejanovski merged commit 580f2d2 into k8ssandra:main Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

K8SSAND-1692 ⁃ Backup can succeed without being marked as finished
2 participants