Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a field to reference a MedusaConfiguration resource in the K8ssandraCluster API #1158

Closed
3 tasks done
Tracked by #1156
adejanovski opened this issue Jan 5, 2024 · 0 comments · Fixed by #1187
Closed
3 tasks done
Tracked by #1156
Assignees
Labels
done Issues in the state 'done'

Comments

@adejanovski
Copy link
Contributor

adejanovski commented Jan 5, 2024

The Medusa spec would contain an additional ObjectReference field to set the reference to the MedusaConfiguration object:

  medusa:
    medusaConfigurationRef:
      name: medusa-storage1
      namespace: ns1
      api: v1alpha1
      kind: MedusaConfiguration
    storageProperties:
      prefix: my-cluster
      transferMaxBandwidth: 150MB/s

The above would generate Medusa storage settings here, with the data stored in the medusa-storage-bucket1 object, and override the prefix and transfer max bandwidth with the provided values.
Merging of both structures would be done with Goalesce, prioritizing the values from storageProperties.
The CreateMedusaIni() function would be refactored to take a MedusaSpec object instead of a K8ssandraCluster one, which would be the result of the above merge.

An additional check would make sure the prefix is explicitly set in storageProperties when a medusaConfigurationRef is set. This will reduce the odds of putting backups from multiple clusters in the same folder.

Definition of Done

Preview Give feedback
@adejanovski adejanovski moved this to Ready in K8ssandra Jan 5, 2024
@adejanovski adejanovski added the ready Issues in the state 'ready' label Jan 5, 2024
@rzvoncek rzvoncek self-assigned this Jan 24, 2024
@rzvoncek rzvoncek moved this from Ready to In Progress in K8ssandra Jan 24, 2024
@adejanovski adejanovski added in-progress Issues in the state 'in-progress' and removed ready Issues in the state 'ready' labels Jan 24, 2024
@rzvoncek rzvoncek moved this from In Progress to Ready For Review in K8ssandra Jan 26, 2024
@adejanovski adejanovski added ready-for-review Issues in the state 'ready-for-review' and removed in-progress Issues in the state 'in-progress' labels Jan 26, 2024
@adejanovski adejanovski moved this from Ready For Review to Review in K8ssandra Jan 26, 2024
@adejanovski adejanovski added review Issues in the state 'review' and removed ready-for-review Issues in the state 'ready-for-review' labels Jan 26, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in K8ssandra Jan 29, 2024
@adejanovski adejanovski added done Issues in the state 'done' and removed review Issues in the state 'review' labels Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done Issues in the state 'done'
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants