Ensure all list failures are logged.

k8ssandra · May 20, 2024 · 893c400 · 893c400
1 parent 2456e37
commit 893c400
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/controllers/medusa/medusabackupschedule_controller.go b/controllers/medusa/medusabackupschedule_controller.go
@@ -97,6 +97,7 @@ func (r *MedusaBackupScheduleReconciler) Reconcile(ctx context.Context, req ctrl
 	if nextExecution.Before(now) {
 		if backupSchedule.Spec.ConcurrencyPolicy == batchv1.ForbidConcurrent {
 			if activeTasks, err := r.activeTasks(backupSchedule, dc); err != nil {
+				logger.V(1).Info("failed to get activeTasks", "error", err)
 				return ctrl.Result{}, err
 			} else {
 				if len(activeTasks) > 0 {

diff --git a/controllers/replication/secret_controller.go b/controllers/replication/secret_controller.go
@@ -6,6 +6,7 @@ import (
 	"strings"
 	"sync"
 
+	"github.com/go-logr/logr"
 	"github.com/k8ssandra/k8ssandra-operator/pkg/secret"
 
 	coreapi "github.com/k8ssandra/k8ssandra-operator/apis/k8ssandra/v1alpha1"
@@ -397,9 +398,10 @@ func (s *SecretSyncController) fetchAllMatchingSecrets(ctx context.Context, sele
 	return secrets.Items, nil
 }
 
-func (s *SecretSyncController) SetupWithManager(mgr ctrl.Manager, clusters []cluster.Cluster) error {
+func (s *SecretSyncController) SetupWithManager(mgr ctrl.Manager, clusters []cluster.Cluster, logger logr.Logger) error {
 	err := s.initializeCache()
 	if err != nil {
+		logger.Info("Failed to initialize cache, error", err)
 		return err
 	}