Forbid enabling vector on a CP reaper

k8ssandra · Jul 29, 2024 · 7fc882b · 7fc882b
1 parent 2066607
commit 7fc882b
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 5 deletions.
diff --git a/apis/reaper/v1alpha1/reaper_webhook.go b/apis/reaper/v1alpha1/reaper_webhook.go
@@ -73,9 +73,11 @@ func (r *Reaper) validateReaper() error {
 	if r.Spec.HasReaperRef() {
 		return nil
 	}
-
 	if r.Spec.IsControlPlane() && r.Spec.StorageType != StorageTypeLocal {
-		return fmt.Errorf("a CONTROL_PLANE reaper can only use local storage")
+		return fmt.Errorf("a Control Plane reaper can only use local storage")
+	}
+	if r.Spec.IsControlPlane() && r.Spec.Telemetry != nil && r.Spec.Telemetry.IsVectorEnabled() {
+		return fmt.Errorf("a Control Plane reaper cannot have vector enabled")
 	}
 	if r.Spec.StorageType == StorageTypeLocal {
 		return r.validateReaperWithLocalStorage()

diff --git a/apis/reaper/v1alpha1/reaper_webhook_test.go b/apis/reaper/v1alpha1/reaper_webhook_test.go
@@ -20,6 +20,7 @@ import (
 	"context"
 	"crypto/tls"
 	"fmt"
+	telemetryapi "github.com/k8ssandra/k8ssandra-operator/apis/telemetry/v1alpha1"
 	"net"
 	"path/filepath"
 	"testing"
@@ -149,10 +150,27 @@ func testReaper(t *testing.T) {
 	createNamespace(require, "reaper-namespace")
 	reaper := createMinimalReaperObj("test-reaper", "reaper-namespace")
 
-	reaper.Spec.DatacenterRef = createDatacenterRef()
-	reaper.Spec.ReaperRef = createReaperRef()
-	err := k8sClient.Create(ctx, reaper)
+	reaperWithBothRefs := reaper.DeepCopy()
+	reaperWithBothRefs.Spec.DatacenterRef = createDatacenterRef()
+	reaperWithBothRefs.Spec.ReaperRef = createReaperRef()
+	err := k8sClient.Create(ctx, reaperWithBothRefs)
 	require.Error(err)
+
+	reaperWithTelemetry := reaper.DeepCopy()
+	reaperWithTelemetry.Spec.StorageType = StorageTypeLocal
+	reaperWithTelemetry.Spec.StorageConfig = createTestStorageConfig()
+	reaperWithTelemetry.Spec.Telemetry = &telemetryapi.TelemetrySpec{
+		Vector: &telemetryapi.VectorSpec{
+			Enabled: ptr.To(true),
+		},
+	}
+	err = k8sClient.Create(ctx, reaper)
+	require.Error(err)
+
+	reaperWithoutTelemetry := reaperWithTelemetry.DeepCopy()
+	reaperWithoutTelemetry.Spec.Telemetry.Vector.Enabled = ptr.To(false)
+	err = k8sClient.Create(ctx, reaperWithoutTelemetry)
+	require.NoError(err)
 }
 
 func testLocalStorage(t *testing.T) {