Always use dc.ObjectMeta.Name-pdb for the PodDisruptionBudget #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frivoire
reviewed
Nov 19, 2024
| @@ -31,7 +31,7 @@ func newPodDisruptionBudgetForDatacenter(dc *api.CassandraDatacenter) *policyv1. | |||
|
|
|||
| pdb := &policyv1.PodDisruptionBudget{ | |||
| ObjectMeta: metav1.ObjectMeta{ | |||
| Name: dc.LabelResourceName() + "-pdb", | |||
| Name: dc.Name + "-pdb", | |||
There was a problem hiding this comment.
Why use a -pdb suffix here ?
It seems useless to me, since K8S resource name only needs to be unique for a given kind of resource.
So, I would suggest to:
Suggested change
| Name: dc.Name + "-pdb", | |
| Name: dc.Name, |
There was a problem hiding this comment.
You're right that it would be enough without the pdb suffix, but in this case the name was picked years ago. For most clusters created with cass-operator, this change will make no difference and the backwards compatibility is retained without any extra objects.
adejanovski
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Uses the ObjectMeta.Name of the CassandraDatacenter for the pdb name prefix instead of the Spec.DatacenterName
Which issue(s) this PR fixes:
Fixes #720
Checklist