Allow PVC expansion #670
Merged
Allow PVC expansion #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO Add new experimental opt-in for this feature (so no one accidentially messes up their cluster). Was thinking |
rzvoncek
reviewed
Jul 10, 2024
|
Those two tests are expected to fail at this point. |
burmanm
force-pushed
the
pvc_expansion
branch
2 times, most recently
from
7b066ba to
56fca3e
Compare
adejanovski
reviewed
Jul 12, 2024
| verifyDatacenterDeleted(ctx, dcName).Should(Succeed()) | ||
| }) | ||
| }) | ||
| // This isn't functional with envtest at the moment, fails with (only in envtest): |
There was a problem hiding this comment.
suggestion: remove the commented code
pkg/reconciliation/handler.go
Outdated
| @@ -121,6 +121,8 @@ func (rc *ReconciliationContext) IsValid(dc *api.CassandraDatacenter) error { | |||
| return errs[0] | |||
| } | |||
|
|
|||
| // TODO Verify if we can expand the PVC or should we reject changes | |||
There was a problem hiding this comment.
question: we're not doing it in this PR? Any potential problem if we don't do the checks like the cluster breaking?
There was a problem hiding this comment.
We do check, this is just another place where I was planning to do the same check previously. I'll remove this comment.
adejanovski
approved these changes
Jul 15, 2024
… ability to verify if StorageClass supports resizing Add resize functionality, new DatacenterCondition to indicate Resizing is happening Patch the PVC and reconcile in 10 seconds Fix existing tests Add validation test Implement unit tests and fix the implementation of expansion Let VoluemResize actually just continue instead of waiting for the PVC resize, we will do a requeue and check there before recreating the StatefulSet Add RBAC role for StorageClasses Fix lint issues, update versions of tools Add e2e test for the PVC expansion using TopoLVM Disable StorageConfig webhook validation failure Improve failure logs with dump of pvc and pv also Move datacenterCondition reset for ResizingVolumes Log also StatefulSets, add annotation to allow StorageConfig changes Add validation if PVC expansion is allowed, modify the behavior to keep the existing PersistentVolumeClaims in the StS, but modifying the sizes only Update controller-runtime to 0.17.4 and update some logging Update docker/build-push-action from v4 to v6 Add CHANGELOG, return all the other e2e tests, update Cassandra/DSE versions Modify the annotation check to happen in the CheckVolumeClaimSizes() instead of CheckRackPodTemplate() to ensure rest of the validations would still always happen. Also, modify the envtests to use more re-usable AsyncAssertions. Add new events to indicate when Datacenter was set to Valid: False
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Support modifying the CassandraDataVolumeClaimSpec sizes if the underlying StorageClass supports it and an annotation
cassandra.datastax.com/allow-storage-changes: trueis placed on the CassandraDatacenter. The operator will automatically increase the size of the PVC and wait for the expansion to finish.Which issue(s) this PR fixes:
Fixes #263
Fixes #668
Checklist