Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AdditionalAnnotations field and logic to reconcile it #601

Merged

Conversation

Miles-Garnsey
Copy link
Member

What this PR does:

Fixes #600

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@Miles-Garnsey Miles-Garnsey requested a review from a team as a code owner December 19, 2023 04:25
@Miles-Garnsey Miles-Garnsey force-pushed the feature/additional-annotations branch from 2bd31b4 to e17c5c0 Compare December 19, 2023 06:06
@Miles-Garnsey Miles-Garnsey self-assigned this Dec 19, 2023
@Miles-Garnsey Miles-Garnsey added the ready-for-review Issues in the state 'ready-for-review' label Dec 19, 2023
@Miles-Garnsey
Copy link
Member Author

Manually testing:

$ kubectl get services -n cass-operator -o json | jq '.items[] | .metadata.name, .metadata.annotations."test-annotation"'
"cass-operator-webhook-service"
null
"cluster1-dc1-additional-seed-service"
"is-here"
"cluster1-dc1-all-pods-service"
"is-here"
"cluster1-dc1-service"
"is-here"
"cluster1-seed-service"
"is-here

$ kubectl get secrets -n cass-operator -o json | jq '.items[] | .metadata.name, .metadata.annotations."test-annotation"'
"cass-operator-controller-manager-token-t478h"
null
"cluster1-superuser"
"is-here"
"default-token-h6pfj"
null
"webhook-server-cert"
null

$kubectl get pods -n cass-operator -o json | jq '.items[] | .metadata.name, .metadata.annotations."test-annotation"'
"cass-operator-controller-manager-dc8d5f5df-jscb8"
null
"cluster1-dc1-default-sts-0"
"is-here"

kubectl get sts -n cass-operator -o json | jq '.items[] | .metadata.name, .metadata.annotations."test-annotation"'
"cluster1-dc1-default-sts"
"is-here"

Looks like all secrets, services, pods and statefulsets receieve the desired annotations.

@Miles-Garnsey
Copy link
Member Author

@burmanm can I get an approval on this when you get a sec?

pkg/oplabels/labels.go Outdated Show resolved Hide resolved
@burmanm burmanm merged commit 4215a60 into k8ssandra:master Jan 9, 2024
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review Issues in the state 'ready-for-review'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AdditionalAnnotations field
2 participants