-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow management-api in different port #242
Comments
And/or we should also allow management api initialization to be captured and mocked so that we could inject httpclient there. |
Hi @burmanm |
Part of the work is done in the envtesting PR. This allows the cass-operator to query the modified port, but it does not yet allow changing them from the CRD. That'll require another set of changes to expose the port settings. |
What is the problem with CRD? Could you pls elaborate on it? |
There's nothing in the CRD that would allow overriding ports. The ports are currently hardcoded in cass-operator. That said, I could enable changing them through the PodTemplateSpec in the containerPorts, but that would be somewhat hidden feature in that case. Maybe that would be fine. |
Actually, there's no need to do any of that, we already supported it in the PodTemplateSpec. See the test in commit 52a430d That would change the mgmt-api port that cass-operator calls. It does not however modify the port that management-api itself listens to. That's defined in the Dockerfile entrypoitn of mgmt-api: Which you will need to override for mgmt-api to listen to in a different port. That's the problem with running in hostnetwork for everything, we can't do do port forwards. |
What is missing?
Currently management-api is considered to be always in the port 8080 by the cass-operator. We should allow PodHost to define a port as well to simplify testing and potentially allow deployments where the port is different.
┆Issue is synchronized with this Jira Story by Unito
┆Issue Number: CASS-52
The text was updated successfully, but these errors were encountered: