Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nodeStatuses info when a pod is recreated #652

Closed
olim7t opened this issue May 10, 2024 · 1 comment · Fixed by #653
Closed

Update nodeStatuses info when a pod is recreated #652

olim7t opened this issue May 10, 2024 · 1 comment · Fixed by #653
Labels
bug Something isn't working done Issues in the state 'done'

Comments

@olim7t
Copy link
Contributor

olim7t commented May 10, 2024

#638 added the ip and rack fields to nodeStatuses. However this information is not correctly refreshed when a pod is deleted and recreated: the pod IP might change, but the status keeps returning the old IP.

I think this is because I made the changes inside of the if force || nodeStatus.HostID == "" { ... } block. It's probably just a matter of moving them a couple of lines below.

On a side note, it would also be useful to have the CQL port alongside the IP, we can use the opportunity to add it (unless there is a reasonably easy way to infer it from the DC spec).

@olim7t olim7t added the bug Something isn't working label May 10, 2024
@burmanm
Copy link
Contributor

burmanm commented May 13, 2024

On a side note, it would also be useful to have the CQL port alongside the IP, we can use the opportunity to add it (unless there is a reasonably easy way to infer it from the DC spec).

We don't allow changing CQL port at the moment in cass-operator, that work would be relevant to ticket: #242 and requires changes in the port definition codes, which are hardcoded everywhere, like:

namedPort("mgmt-api-http", 8080),

namedServicePort("native", nativePort, nativePort),

So that would be a PR of it's own, requiring design how all the port definitions can be modified, tested, wired to the mgmt-api and supported there also (I'm not sure how much mgmt-api even supports these).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working done Issues in the state 'done'
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants