Publish container image #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeeke
force-pushed
the
us/publish-images
branch
3 times, most recently
from
6f7b664 to
45c830d
Compare
|
@mlguerrero12 @Eoghan1232 @SchSeba please take a look when you have time. |
Eoghan1232
reviewed
Nov 20, 2024
SchSeba
reviewed
Nov 21, 2024
images/Dockerfile
Outdated
| @@ -0,0 +1,15 @@ | |||
| # This Dockerfile is used to build the image available on DockerHub | |||
| FROM golang:1.23 AS build | |||
There was a problem hiding this comment.
nit: can you add docker.io/
images/Dockerfile
Outdated
| COPY . . | ||
| RUN make build-bin | ||
|
|
||
| FROM alpine:latest |
images/Dockerfile
Outdated
| LABEL org.opencontainers.image.source=https://github.com/k8snetworkplumbingwg/bond-cni | ||
| WORKDIR / | ||
| COPY --from=build /usr/src/bond-cni/bin . | ||
| COPY --from=build /usr/src/bond-cni/LICENSE . |
There was a problem hiding this comment.
nit: can we just copy directly and not from the other container?
images/Dockerfile
Outdated
| WORKDIR / | ||
| COPY --from=build /usr/src/bond-cni/bin . | ||
| COPY --from=build /usr/src/bond-cni/LICENSE . | ||
| COPY --from=build /usr/src/bond-cni/images/entrypoint.sh . |
There was a problem hiding this comment.
nit: can we just copy directly and not from the other container?
manifests/bond-cni.yaml
Outdated
| volumes: | ||
| - name: cnibin | ||
| hostPath: | ||
| path: /host/opt/cni/bin/ |
There was a problem hiding this comment.
nit: please add a new line here
manifests/bond-cni.yaml
Outdated
| volumes: | ||
| - name: cnibin | ||
| hostPath: | ||
| path: /host/opt/cni/bin/ |
There was a problem hiding this comment.
This one doesn't see right the hostPath should be opt/cni/bin and inside the container we should have /host/opt/cni/bin/ no?
There was a problem hiding this comment.
right. Also @Eoghan1232 noticed that.
For some reason, it worked on my cluster.
Fixing
Add Dockerfile and related entrypoint.sh to build the binary and copy it to the host. Signed-off-by: Andrea Panattoni <[email protected]>
Add GitHub configuration to publish the docker image with the plugin binary Signed-off-by: Andrea Panattoni <[email protected]>
With this configuration, `bond` CNI plugin can be deployed via: ``` kubectl apply -f https://raw.githubusercontent.com/k8snetworkplumbingwg/bond-cni/master/manifests/bond.yml ``` Signed-off-by: Andrea Panattoni <[email protected]>
zeeke
force-pushed
the
us/publish-images
branch
from
45c830d to
d79f9ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build plugin image
Add Dockerfile and related entrypoint.sh to build the binary and copy
it to the host.
Build and publish images in CI
Add GitHub configuration to publish the docker image with the plugin binary
Deployment file
With this configuration,
bondCNI plugin can be deployed via:Fixes #104