feat: allow service monitor without authentication or with auth data from existing secret #181
Conversation
maxnitze
force-pushed
the
feat/allow-service-monitor-without-or-with-custom-authentication
branch
2 times, most recently
from
06ec3fe to
4f06e99
Compare
…from existing secret
maxnitze
force-pushed
the
feat/allow-service-monitor-without-or-with-custom-authentication
branch
from
4f06e99 to
cf9da31
Compare
k3rnelpan1c-dev
added
documentation
|
Hey, sorry for the late response, been rather busy IRL lately and haven't had the time nor motivation to really give this project the attention it deserves. |
| @@ -106,6 +106,13 @@ affinity: {} | |||
|
|
|||
| serviceMonitor: | |||
| enabled: false | |||
| authentication: | |||
| enabled: true | |||
There was a problem hiding this comment.
only question I have is, why you default it to enabled: true
personally, would default it to false unless uptime-kuma requires it to expose the metrics, but in that case the toggle would be obsolete anyway.
There was a problem hiding this comment.
Could do that, but I wanted to make this non-breaking. And since authentication was enabled beforehand, I kept it. I can also "break" it and disable it by default. Would make more sense from my perspective, too.
|
Hey! I answered your comment. I can switch it, of course. Makes more sense to me as well. Your call :) |
Allow to disable authentication of the service monitor by settings
.Values.serviceAccount.authentication.enabled=false. Also allow to provide an existing secret for the service monitor authentication.