Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added opening PDFs from URL #27

Merged
merged 5 commits into from
Apr 10, 2021
Merged

Added opening PDFs from URL #27

merged 5 commits into from
Apr 10, 2021

Conversation

darkcheftar
Copy link

@darkcheftar darkcheftar commented Apr 7, 2021 •
edited
Loading

Addressing #25 I used cors-anywhere and hosted it at Heroku at This Proxy link following This tutorial. And taking the URL to be opened using prompt and opening the URL using the above proxy.
Taking link using prompt:
image
Opening pdf:
image

@darkcheftar darkcheftar mentioned this pull request Apr 7, 2021
Closed
jzillmann
jzillmann reviewed Apr 9, 2021
View reviewed changes
Copy link
Owner

@jzillmann jzillmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So yeah, looks good to me! I would prefer removing the autoprefixer dependency (unless there is a good reason not to do so) and then it is ready to go!

Btw, was there a specific reason you spawn up your own proxy instead of using an existing on e ?

ui/src/main/Upload.svelte Outdated Show resolved Hide resolved
ui/package.json Outdated Show resolved Hide resolved
@jzillmann jzillmann assigned jzillmann and darkcheftar and unassigned jzillmann Apr 9, 2021
@darkcheftar
Copy link
Author

I cleared the minor inconveniences

  • using let keyword instead of var
  • removing autoprefixer from dependencies

@jzillmann
Copy link
Owner

jzillmann commented Apr 10, 2021 •
edited
Loading

Ok, I was curious about the large changes of package-lock.json and played a bit with it and run in trouble. Seems like the newest version of pdfjs broke something with the worker setup so I pinned all production libs for now!

@jzillmann jzillmann merged commit 6327d74 into jzillmann:modularize Apr 10, 2021
@jzillmann
Copy link
Owner

Merged, thanks for digging in!

@darkcheftar
Copy link
Author

Ok, I was curious about the large changes of package-lock.json and played a bit with it and run in trouble. Seems like the newest version of pdfjs broke something with the worker setup so I pinned all production libs for now!

I didn't noticed that.
Can I do something about it?
Any suggestions?

@jzillmann
Copy link
Owner

👆 if you want you could investigate. Just upgrade to the latest pdfjs and see if it works.

@darkcheftar
Copy link
Author

darkcheftar commented Apr 10, 2021 •
edited
Loading

👆 if you want you could investigate. Just upgrade to the latest pdfjs and see if it works.

sure, I take a look into it sire.

@darkcheftar darkcheftar deleted the modularize branch April 11, 2021 05:39
@darkcheftar
Copy link
Author

👆 if you want you could investigate. Just upgrade to the latest pdfjs and see if it works.

sire @jzillmann , actually I wanted to do this but I didn't understood what to do exactly.
do I just need to update pdfjs or do I need to run npm update or something.
could you please explain what to do in detail if possible?

@jzillmann
Copy link
Owner

So since this is totally different issue I created #28 for it!
I put more details into it. If somethings missing, let me know!

@darkcheftar
Copy link
Author

So since this is totally different issue I created #28 for it!
I put more details into it. If somethings missing, let me know!

sure, sire

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzillmann jzillmann jzillmann approved these changes

Assignees

@darkcheftar darkcheftar

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darkcheftar @jzillmann