Optimize build from source #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `npm_config_nodedir` since we need native modules for electron - Don't disable rebuilding native modules - Remove redundant environment variables - Use `jq` to edit package.json - Use `.yarnrc` files instead of passing `--offline` cli arg - Add empty lines between modules and sources for readability
Query Github API for Element releases; GitChecker has issues when used for apps with downstream .metainfo.xml. Also fix URL template for Yarn.
3 tasks
jwillikers
approved these changes
Aug 19, 2021
| type: git | ||
| tag-pattern: ^v([\\d.]+)$ | ||
| version-scheme: semantic | ||
| type: json |
There was a problem hiding this comment.
I'm just curious about why you choose the json x-checker-data?
There was a problem hiding this comment.
Because json checker can get stable timestamps, unlike git checker, see flathub-infra/flatpak-external-data-checker#154
| # Rebuild native modules by electron-rebuild | ||
| # https://github.com/electron-userland/electron-builder/issues/4100 | ||
| - sed -i 's/"build":\ {/"build":\ {\n"npmRebuild":\ false,/' package.json | ||
| - jq 'del(.build.electronVersion)' <<<$(cat package.json) > package.json |
There was a problem hiding this comment.
Using jq is much better idea...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm_config_nodedirsince we need native modules for electronjqto edit package.json.yarnrcfiles instead of passing--offlinecli arg