Merge pull request #79 from azzang/fix/too-many-connection-attempts

fix: Prevent too many connection attempts on error

package.json

@@ -23,6 +23,7 @@
     "chai-as-promised": "^7.1.1",
     "chai-string": "^1.1.2",
     "coveralls": "^3.0.0",
+    "cross-env": "^5.2.0",
     "eslint": "^5.14.1",
     "eslint-config-benbria": "^4.0.0",
     "eslint-plugin-import": "^2.11.0",
@@ -47,9 +48,9 @@
     "build": "babel -s -d lib src",
     "clean": "rm -rf lib coverage",
     "test": "npm run test:lint && npm run test:unittest",
-    "test:unittest": "NODE_ENV=test nyc mocha",
+    "test:unittest": "cross-env NODE_ENV=test nyc mocha",
     "test:lint": "eslint src test",
-    "precommit:unittest": "BABEL_DISABLE_CACHE=1 NODE_ENV=test nyc mocha --reporter progress",
+    "precommit:unittest": "cross-env BABEL_DISABLE_CACHE=1 cross-env NODE_ENV=test nyc mocha --reporter progress",
     "semantic-release": "semantic-release"
   },
   "husky": {

src/AmqpConnectionManager.js

@@ -148,21 +148,15 @@ export default class AmqpConnectionManager extends EventEmitter {
 
                 connection.on('unblocked', () => this.emit('unblocked'));
 
-                // Reconnect if the broker goes away.
-                connection.on('error', err =>
-                    Promise.resolve()
-                    .then(() =>this._currentConnection.close())
-                    .catch(() => { /* Ignore */ })
-                    .then(() => {
-                        this._currentConnection = null;
-                        this.emit('disconnect', { err });
-                        return this._connect();
-                    })
-                    // `_connect()` should never throw.
-                    .catch(neverThrows)
-                );
+                connection.on('error', (/* err */) => {
+                    // if this event was emitted, then the connection was already closed,
+                    // so no need to call #close here
+                    // also, 'close' is emitted after 'error',
+                    // so no need for work already done in 'close' handler
+                    return Promise.resolve();
+                });
 
-                // Reconnect if the connection closes gracefully
+                // Reconnect if the connection closes
                 connection.on('close', err => {
                     this._currentConnection = null;
                     this.emit('disconnect', { err });

test/fixtures.js

@@ -5,7 +5,9 @@ export class FakeAmqp {
     constructor() { this.reset(); }
 
     kill() {
-        this.connection.emit('error', new Error("Died in a fire"));
+        const err = new Error("Died in a fire");
+        this.connection.emit('error', err);
+        this.connection.emit('close', err);
     }
 
     simulateRemoteClose() {