Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gracefully recover from link loading errors #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bennypowers
Copy link
Contributor

@bennypowers bennypowers commented Mar 24, 2022

Depends on #20

Before: entire partial fails to load if subresource errors:
After: log the failed URL and continue

See tests: without this PR, the shadow content of the partial does not appear on the page

bennypowers added a commit to patternfly/patternfly-elements that referenced this pull request Mar 24, 2022
bennypowers added a commit to patternfly/patternfly-elements that referenced this pull request Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant