Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-docs): DSW-2496 radio-group overview page #2053

Merged
merged 27 commits into from
Nov 19, 2024

Conversation

jamieomaguire
Copy link
Contributor

@jamieomaguire jamieomaguire commented Nov 12, 2024

Describe your changes (can list changeset entries if preferable)

  • Completed radio button overview page in docs site
  • Added the missing index card for checkbox group
  • Extended the error messaging for index cards to tell the developer where the missing image was expected to be

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • I have reviewed visual test updates properly before approving

Reviewer checklists (complete before approving)

Reviewer 1 - @siggerzz

  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

Reviewer 2 @raoufswe

  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

Copy link

changeset-bot bot commented Nov 13, 2024

⚠️ No Changeset found

Latest commit: 1b846a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jamieomaguire jamieomaguire marked this pull request as ready for review November 13, 2024 10:52
@jamieomaguire jamieomaguire requested review from a team as code owners November 13, 2024 10:52
@jamieomaguire jamieomaguire self-assigned this Nov 14, 2024
Copy link
Member

@raoufswe raoufswe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like one of the images isn't loading
Screenshot 2024-11-14 at 10 08 02

raoufswe
raoufswe previously approved these changes Nov 14, 2024
siggerzz
siggerzz previously approved these changes Nov 14, 2024
@jamieomaguire jamieomaguire dismissed stale reviews from siggerzz and raoufswe via 6cffaf6 November 19, 2024 12:44
@jamieomaguire jamieomaguire merged commit 8a4c425 into main Nov 19, 2024
30 of 31 checks passed
@jamieomaguire jamieomaguire deleted the DSW-2496-radio-group-overview branch November 19, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants