Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps)!: update to Angular 19 #1871

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Builders' and Angular **major** versions **must** match.
<details>
<summary>Click to expand</summary>

- [Version 18](https://github.com/just-jeb/angular-builders/tree/18.x.x)
- [Version 17](https://github.com/just-jeb/angular-builders/tree/17.x.x)
- [Version 16](https://github.com/just-jeb/angular-builders/tree/16.x.x)
- [Version 15](https://github.com/just-jeb/angular-builders/tree/15.x.x)
Expand Down
2 changes: 1 addition & 1 deletion examples/bazel/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
"private": true,
"devDependencies": {
"@angular-builders/bazel": "workspace:*",
"@angular/cli": "18.1.4"
"@angular/cli": "19.0.0"
}
}
28 changes: 14 additions & 14 deletions examples/custom-esbuild/sanity-esbuild-app-esm/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,24 +15,24 @@
},
"private": true,
"dependencies": {
"@angular/animations": "18.1.3",
"@angular/common": "18.1.3",
"@angular/compiler": "18.1.3",
"@angular/core": "18.1.3",
"@angular/forms": "18.1.3",
"@angular/platform-browser": "18.1.3",
"@angular/platform-browser-dynamic": "18.1.3",
"@angular/router": "18.1.3",
"@angular/animations": "19.0.0",
"@angular/common": "19.0.0",
"@angular/compiler": "19.0.0",
"@angular/core": "19.0.0",
"@angular/forms": "19.0.0",
"@angular/platform-browser": "19.0.0",
"@angular/platform-browser-dynamic": "19.0.0",
"@angular/router": "19.0.0",
"rxjs": "7.8.1",
"tslib": "2.6.3",
"zone.js": "0.14.8"
"zone.js": "0.15.0"
},
"devDependencies": {
"@angular-builders/custom-esbuild": "workspace:*",
"@angular-devkit/build-angular": "18.1.4",
"@angular/cli": "18.1.4",
"@angular/compiler-cli": "18.1.3",
"@angular/language-service": "18.1.3",
"@angular-devkit/build-angular": "19.0.0",
"@angular/cli": "19.0.0",
"@angular/compiler-cli": "19.0.0",
"@angular/language-service": "19.0.0",
"@types/jasmine": "5.1.2",
"@types/node": "20.17.8",
"cypress": "13.16.0",
Expand All @@ -44,6 +44,6 @@
"karma-jasmine-html-reporter": "2.1.0",
"puppeteer": "20.9.0",
"ts-node": "10.9.2",
"typescript": "5.4.5"
"typescript": "5.6.2"
}
}
28 changes: 14 additions & 14 deletions examples/custom-esbuild/sanity-esbuild-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,24 +12,24 @@
},
"private": true,
"dependencies": {
"@angular/animations": "18.1.3",
"@angular/common": "18.1.3",
"@angular/compiler": "18.1.3",
"@angular/core": "18.1.3",
"@angular/forms": "18.1.3",
"@angular/platform-browser": "18.1.3",
"@angular/platform-browser-dynamic": "18.1.3",
"@angular/router": "18.1.3",
"@angular/animations": "19.0.0",
"@angular/common": "19.0.0",
"@angular/compiler": "19.0.0",
"@angular/core": "19.0.0",
"@angular/forms": "19.0.0",
"@angular/platform-browser": "19.0.0",
"@angular/platform-browser-dynamic": "19.0.0",
"@angular/router": "19.0.0",
"rxjs": "7.8.1",
"tslib": "2.6.3",
"zone.js": "0.14.8"
"zone.js": "0.15.0"
},
"devDependencies": {
"@angular-builders/custom-esbuild": "workspace:*",
"@angular-devkit/build-angular": "18.1.4",
"@angular/cli": "18.1.4",
"@angular/compiler-cli": "18.1.3",
"@angular/language-service": "18.1.3",
"@angular-devkit/build-angular": "19.0.0",
"@angular/cli": "19.0.0",
"@angular/compiler-cli": "19.0.0",
"@angular/language-service": "19.0.0",
"@types/jasmine": "5.1.2",
"@types/node": "20.17.8",
"cypress": "13.16.0",
Expand All @@ -41,6 +41,6 @@
"karma-jasmine-html-reporter": "2.1.0",
"puppeteer": "20.9.0",
"ts-node": "10.9.2",
"typescript": "5.4.5"
"typescript": "5.6.2"
}
}
8 changes: 4 additions & 4 deletions examples/custom-webpack/full-cycle-app/angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,22 +81,22 @@
"serve": {
"builder": "@angular-builders/custom-webpack:dev-server",
"options": {
"browserTarget": "full-cycle-app:build",
"buildTarget": "full-cycle-app:build",
"port": 5000
},
"configurations": {
"production": {
"browserTarget": "full-cycle-app:build:production"
"buildTarget": "full-cycle-app:build:production"
},
"itwcw": {
"browserTarget": "full-cycle-app:build:itwcw"
"buildTarget": "full-cycle-app:build:itwcw"
}
}
},
"extract-i18n": {
"builder": "@angular-devkit/build-angular:extract-i18n",
"options": {
"browserTarget": "full-cycle-app:build"
"buildTarget": "full-cycle-app:build"
}
},
"test": {
Expand Down
28 changes: 14 additions & 14 deletions examples/custom-webpack/full-cycle-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,24 +12,24 @@
},
"private": true,
"dependencies": {
"@angular/animations": "18.1.3",
"@angular/common": "18.1.3",
"@angular/compiler": "18.1.3",
"@angular/core": "18.1.3",
"@angular/forms": "18.1.3",
"@angular/platform-browser": "18.1.3",
"@angular/platform-browser-dynamic": "18.1.3",
"@angular/router": "18.1.3",
"@angular/animations": "19.0.0",
"@angular/common": "19.0.0",
"@angular/compiler": "19.0.0",
"@angular/core": "19.0.0",
"@angular/forms": "19.0.0",
"@angular/platform-browser": "19.0.0",
"@angular/platform-browser-dynamic": "19.0.0",
"@angular/router": "19.0.0",
"rxjs": "7.8.1",
"tslib": "2.6.3",
"zone.js": "0.14.8"
"zone.js": "0.15.0"
},
"devDependencies": {
"@angular-builders/custom-webpack": "workspace:*",
"@angular-devkit/build-angular": "18.1.4",
"@angular/cli": "18.1.4",
"@angular/compiler-cli": "18.1.3",
"@angular/language-service": "18.1.3",
"@angular-devkit/build-angular": "19.0.0",
"@angular/cli": "19.0.0",
"@angular/compiler-cli": "19.0.0",
"@angular/language-service": "19.0.0",
"@types/jasmine": "5.1.4",
"@types/node": "20.17.8",
"cypress": "13.16.0",
Expand All @@ -42,6 +42,6 @@
"karma-jasmine-html-reporter": "2.1.0",
"puppeteer": "21.11.0",
"ts-node": "10.9.2",
"typescript": "5.4.5"
"typescript": "5.6.2"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,47 +2,33 @@ import { TestBed, waitForAsync } from '@angular/core/testing';
import { AppComponent } from '@app/app.component';

describe('AppComponent', () => {
beforeEach(
waitForAsync(() => {
Object.defineProperty(window, 'APP_VERSION', { value: `fake version`, writable: false });
beforeEach(waitForAsync(() => {
Object.defineProperty(window, 'APP_VERSION', { value: `fake version`, writable: false });

TestBed.configureTestingModule({
declarations: [AppComponent],
}).compileComponents();
})
);
it(
'should create the app',
waitForAsync(() => {
const fixture = TestBed.createComponent(AppComponent);
const app = fixture.debugElement.componentInstance;
expect(app).toBeTruthy();
})
);
it(
`should have as title 'app'`,
waitForAsync(() => {
const fixture = TestBed.createComponent(AppComponent);
const app = fixture.debugElement.componentInstance;
expect(app.title).toEqual('full-cycle-app');
})
);
it(
'should render title in a h1 tag',
waitForAsync(() => {
const fixture = TestBed.createComponent(AppComponent);
fixture.detectChanges();
const compiled = fixture.debugElement.nativeElement;
expect(compiled.querySelector('h1').textContent).toContain('Welcome to full-cycle-app!');
})
);
it(
'should render `version` in div with `version` css class',
waitForAsync(() => {
const fixture = TestBed.createComponent(AppComponent);
fixture.detectChanges();
const compiled = fixture.debugElement.nativeElement;
expect(compiled.querySelector('.version').textContent).toContain('fake version');
})
);
TestBed.configureTestingModule({
imports: [AppComponent],
}).compileComponents();
}));
it('should create the app', waitForAsync(() => {
const fixture = TestBed.createComponent(AppComponent);
const app = fixture.debugElement.componentInstance;
expect(app).toBeTruthy();
}));
it(`should have as title 'app'`, waitForAsync(() => {
const fixture = TestBed.createComponent(AppComponent);
const app = fixture.debugElement.componentInstance;
expect(app.title).toEqual('full-cycle-app');
}));
it('should render title in a h1 tag', waitForAsync(() => {
const fixture = TestBed.createComponent(AppComponent);
fixture.detectChanges();
const compiled = fixture.debugElement.nativeElement;
expect(compiled.querySelector('h1').textContent).toContain('Welcome to full-cycle-app!');
}));
it('should render `version` in div with `version` css class', waitForAsync(() => {
const fixture = TestBed.createComponent(AppComponent);
fixture.detectChanges();
const compiled = fixture.debugElement.nativeElement;
expect(compiled.querySelector('.version').textContent).toContain('fake version');
}));
});
11 changes: 0 additions & 11 deletions examples/custom-webpack/full-cycle-app/src/app/app.module.ts

This file was deleted.

8 changes: 3 additions & 5 deletions examples/custom-webpack/full-cycle-app/src/main.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
import { enableProdMode } from '@angular/core';
import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';
import { AppModule } from '@app/app.module';
import { bootstrapApplication } from '@angular/platform-browser';
import { AppComponent } from '@app/app.component';
import { environment } from '@environment';

if (environment.production) {
enableProdMode();
}

platformBrowserDynamic()
.bootstrapModule(AppModule)
.catch(err => console.error(err));
bootstrapApplication(AppComponent);
12 changes: 6 additions & 6 deletions examples/custom-webpack/sanity-app-esm/angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,26 +95,26 @@
},
"configurations": {
"production": {
"browserTarget": "sanity-app-esm:build:production"
"buildTarget": "sanity-app-esm:build:production"
},
"development": {
"browserTarget": "sanity-app-esm:build:development"
"buildTarget": "sanity-app-esm:build:development"
},
"cjs": {
"browserTarget": "sanity-app-esm:build:cjs"
"buildTarget": "sanity-app-esm:build:cjs"
},
"esm": {
"browserTarget": "sanity-app-esm:build:esm"
"buildTarget": "sanity-app-esm:build:esm"
},
"tsEsm": {
"browserTarget": "sanity-app-esm:build:tsEsm"
"buildTarget": "sanity-app-esm:build:tsEsm"
}
}
},
"extract-i18n": {
"builder": "@angular-devkit/build-angular:extract-i18n",
"options": {
"browserTarget": "sanity-app-esm:build"
"buildTarget": "sanity-app-esm:build"
}
},
"test": {
Expand Down
26 changes: 13 additions & 13 deletions examples/custom-webpack/sanity-app-esm/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,23 +16,23 @@
},
"private": true,
"dependencies": {
"@angular/animations": "18.1.3",
"@angular/common": "18.1.3",
"@angular/compiler": "18.1.3",
"@angular/core": "18.1.3",
"@angular/forms": "18.1.3",
"@angular/platform-browser": "18.1.3",
"@angular/platform-browser-dynamic": "18.1.3",
"@angular/router": "18.1.3",
"@angular/animations": "19.0.0",
"@angular/common": "19.0.0",
"@angular/compiler": "19.0.0",
"@angular/core": "19.0.0",
"@angular/forms": "19.0.0",
"@angular/platform-browser": "19.0.0",
"@angular/platform-browser-dynamic": "19.0.0",
"@angular/router": "19.0.0",
"rxjs": "7.8.1",
"tslib": "2.6.3",
"zone.js": "0.14.8"
"zone.js": "0.15.0"
},
"devDependencies": {
"@angular-builders/custom-webpack": "workspace:*",
"@angular-devkit/build-angular": "18.1.4",
"@angular/cli": "18.1.4",
"@angular/compiler-cli": "18.1.3",
"@angular-devkit/build-angular": "19.0.0",
"@angular/cli": "19.0.0",
"@angular/compiler-cli": "19.0.0",
"@cypress/schematic": "2.5.2",
"@types/jasmine": "5.1.4",
"@types/node": "20.17.8",
Expand All @@ -44,6 +44,6 @@
"karma-jasmine": "5.1.0",
"karma-jasmine-html-reporter": "2.1.0",
"puppeteer": "21.11.0",
"typescript": "5.4.5"
"typescript": "5.6.2"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { AppComponent } from './app.component';
describe('AppComponent', () => {
beforeEach(async () => {
await TestBed.configureTestingModule({
declarations: [AppComponent],
imports: [AppComponent],
}).compileComponents();
});

Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import { CommonModule } from '@angular/common';
import { Component } from '@angular/core';

@Component({
selector: 'app-root',
templateUrl: './app.component.html',
styleUrls: ['./app.component.css'],
imports: [CommonModule],
})
export class AppComponent {
title = 'sanity-app-esm';
Expand Down
12 changes: 0 additions & 12 deletions examples/custom-webpack/sanity-app-esm/src/app/app.module.ts

This file was deleted.

Loading