Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for deno compile sub command #112

Closed
wants to merge 1 commit into from
Closed

feat: Add support for deno compile sub command #112

wants to merge 1 commit into from

Conversation

DerZade
Copy link

@DerZade DerZade commented May 2, 2022

This PR will enable option passing to deno's compile sub-command.

(I hope this is all that's required for that)

@umbopepato
Copy link
Member

Hey @DerZade, thank you so much for the PR!
While we're at it: the options accepted by vr are currently misaligned wrt the latest versions of Deno (see #113 for example) so it would probably make sense to check all the commands and update the accepted options. If you could do it and update this PR it would be much appreciated 🤗

@DerZade
Copy link
Author

DerZade commented Sep 29, 2022

Hey @DerZade, thank you so much for the PR! While we're at it: the options accepted by vr are currently misaligned wrt the latest versions of Deno (see #113 for example) so it would probably make sense to check all the commands and update the accepted options. If you could do it and update this PR it would be much appreciated 🤗

I was going to just do it, but as you can see it's been months without any commits. 😅 I can just not find the time.

Can we merge this anyway?

@DerZade DerZade closed this Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants