Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

Add more skip-if-exists, fix wheel packaging #181

Merged
merged 11 commits into from
Oct 18, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Oct 17, 2023

Follow-up to #179

@github-actions
Copy link
Contributor

lite-badge 👈 Try it on ReadTheDocs

@jtpio
Copy link
Member Author

jtpio commented Oct 18, 2023

So there seems to be an issue with hatch not including files ignored in a .gitignore.

It looks related to https://hatch.pypa.io/latest/config/build/#vcs at first, although it's not clear because adding an explicit include does include the missed files (.wasm, .tar.gz) to be included in the wheel, but not in the .data when listed in shared-data...

@jtpio
Copy link
Member Author

jtpio commented Oct 18, 2023

Just tried locally with the built wheel from the releaser assets and it seems fine:

image

Gonna log this hatch quirk in an issue and proceed with a new release, so the latest jupyterlite-xeus-python alpha is usable.

@jtpio
Copy link
Member Author

jtpio commented Oct 18, 2023

Gonna log this hatch quirk in an issue and proceed with a new release, so the latest jupyterlite-xeus-python alpha is usable.

Opened #182

@jtpio jtpio merged commit 90f5ac5 into jupyterlite:main Oct 18, 2023
13 checks passed
@jtpio jtpio deleted the fix-packaging-2 branch October 18, 2023 08:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant