Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

Commit

Permalink
try increase timeout for webkit
Browse files Browse the repository at this point in the history
  • Loading branch information
jtpio committed Oct 13, 2023
1 parent 9300c13 commit dcf934f
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion ui-tests/test/execute.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,11 @@ test.describe('Code execution', () => {
await page.goto('lab/index.html');
});

test('Basic code execution', async ({ page }) => {
test('Basic code execution', async ({ page, browserName }) => {
if (browserName === 'webkit') {
// try waiting longer for webkit
test.setTimeout(60000 * 3);
}
await page.notebook.createNew();
await page.notebook.setCell(0, 'code', '2 + 2');
await page.notebook.run();

Check failure on line 24 in ui-tests/test/execute.test.ts

View workflow job for this annotation

GitHub Actions / Visual Regression (webkit)

[webkit] › test/execute.test.ts:17:7 › Code execution › Basic code execution

1) [webkit] › test/execute.test.ts:17:7 › Code execution › Basic code execution ────────────────── Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: locator.waitFor: Page closed =========================== logs =========================== waiting for locator('#jp-main-statusbar').locator('text=Idle') to be visible ============================================================ 22 | await page.notebook.createNew(); 23 | await page.notebook.setCell(0, 'code', '2 + 2'); > 24 | await page.notebook.run(); | ^ 25 | const output = await page.notebook.getCellTextOutput(0); 26 | 27 | expect(output).toBeTruthy(); at NotebookHelper.waitForRun (/home/runner/work/xeus-python-kernel/xeus-python-kernel/ui-tests/node_modules/@jupyterlab/galata/src/helpers/notebook.ts:385:23) at NotebookHelper.run (/home/runner/work/xeus-python-kernel/xeus-python-kernel/ui-tests/node_modules/@jupyterlab/galata/src/helpers/notebook.ts:276:16) at /home/runner/work/xeus-python-kernel/xeus-python-kernel/ui-tests/test/execute.test.ts:24:5
Expand Down

0 comments on commit dcf934f

Please sign in to comment.