Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

Commit

Permalink
try fix ui tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@jtpio
jtpio committed Oct 13, 2023
1 parent 0dbbaea commit 99469ad
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions ui-tests/test/execute.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ test.describe('Code execution', () => {
test.setTimeout(60000 * 3);
}
await page.notebook.createNew();

// TODO: remove
// See https://github.com/jupyterlab/jupyterlab/issues/15252 for more information
await page.notebook.setCell(0, 'code', '2 + 2');
await page.notebook.setCell(0, 'code', '2 + 2');
await page.notebook.run();

Check failure on line 28 in ui-tests/test/execute.test.ts

View workflow job for this annotation

GitHub Actions / Visual Regression (webkit)

[webkit] › test/execute.test.ts:17:7 › Code execution › Basic code execution 

  1) [webkit] › test/execute.test.ts:17:7 › Code execution › Basic code execution ──────────────────
    Error: locator.waitFor: Page closed
    =========================== logs ===========================
    waiting for locator('#jp-main-statusbar').locator('text=Idle') to be visible
    ============================================================

      26 |     await page.notebook.setCell(0, 'code', '2 + 2');
      27 |     await page.notebook.setCell(0, 'code', '2 + 2');
    > 28 |     await page.notebook.run();
         |     ^
      29 |     const output = await page.notebook.getCellTextOutput(0);
      30 |
      31 |     expect(output).toBeTruthy();

        at NotebookHelper.waitForRun (/home/runner/work/xeus-python-kernel/xeus-python-kernel/ui-tests/node_modules/@jupyterlab/galata/src/helpers/notebook.ts:385:23)
        at NotebookHelper.run (/home/runner/work/xeus-python-kernel/xeus-python-kernel/ui-tests/node_modules/@jupyterlab/galata/src/helpers/notebook.ts:276:16)
        at /home/runner/work/xeus-python-kernel/xeus-python-kernel/ui-tests/test/execute.test.ts:28:5

Check failure on line 28 in ui-tests/test/execute.test.ts

View workflow job for this annotation

GitHub Actions / Visual Regression (webkit)

[webkit] › test/execute.test.ts:17:7 › Code execution › Basic code execution 

  1) [webkit] › test/execute.test.ts:17:7 › Code execution › Basic code execution ──────────────────

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: locator.waitFor: Page closed
    =========================== logs ===========================
    waiting for locator('#jp-main-statusbar').locator('text=Idle') to be visible
    ============================================================

      26 |     await page.notebook.setCell(0, 'code', '2 + 2');
      27 |     await page.notebook.setCell(0, 'code', '2 + 2');
    > 28 |     await page.notebook.run();
         |     ^
      29 |     const output = await page.notebook.getCellTextOutput(0);
      30 |
      31 |     expect(output).toBeTruthy();

        at NotebookHelper.waitForRun (/home/runner/work/xeus-python-kernel/xeus-python-kernel/ui-tests/node_modules/@jupyterlab/galata/src/helpers/notebook.ts:385:23)
        at NotebookHelper.run (/home/runner/work/xeus-python-kernel/xeus-python-kernel/ui-tests/node_modules/@jupyterlab/galata/src/helpers/notebook.ts:276:16)
        at /home/runner/work/xeus-python-kernel/xeus-python-kernel/ui-tests/test/execute.test.ts:28:5

Check failure on line 28 in ui-tests/test/execute.test.ts

View workflow job for this annotation

GitHub Actions / Visual Regression (webkit)

[webkit] › test/execute.test.ts:17:7 › Code execution › Basic code execution 

  2) [webkit] › test/execute.test.ts:17:7 › Code execution › Basic code execution ──────────────────
    Error: locator.waitFor: Page closed
    =========================== logs ===========================
    waiting for locator('#jp-main-statusbar').locator('text=Idle') to be visible
    ============================================================

      26 |     await page.notebook.setCell(0, 'code', '2 + 2');
      27 |     await page.notebook.setCell(0, 'code', '2 + 2');
    > 28 |     await page.notebook.run();
         |     ^
      29 |     const output = await page.notebook.getCellTextOutput(0);
      30 |
      31 |     expect(output).toBeTruthy();

        at NotebookHelper.waitForRun (/home/runner/work/xeus-python-kernel/xeus-python-kernel/ui-tests/node_modules/@jupyterlab/galata/src/helpers/notebook.ts:385:23)
        at NotebookHelper.run (/home/runner/work/xeus-python-kernel/xeus-python-kernel/ui-tests/node_modules/@jupyterlab/galata/src/helpers/notebook.ts:276:16)
        at /home/runner/work/xeus-python-kernel/xeus-python-kernel/ui-tests/test/execute.test.ts:28:5
const output = await page.notebook.getCellTextOutput(0);
Expand Down

0 comments on commit 99469ad

Please sign in to comment.