Start jupyter server in child process and launch render process with token. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WOOOOOAH |
nproctor
approved these changes
Jun 22, 2017
|
@lucbouchard1 why did you remove electron-prebuilt-compile and used vanilla typescript instead? |
|
@ddavidebor I was having problems with the build and changed it out of frustration. I think I have more of a grip on how to configure it now so I will change it back. I agree it's better with electron-prebuilt-compile. I'll open an issue. |
|
For future reference: the issue is #28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes issue #12 . The server is launched in a child process and the token is collect using
jupyter notebook list. The token is then injected into the frontend html using Handlebars.