Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pip-only install/CLI smoke test #456

Merged

Conversation

bollwyvl
Copy link
Collaborator

@bollwyvl bollwyvl commented Jan 6, 2021

References

Code changes

Adds a pip-only install test to CI (doesn't even do a checkout). By making these rely on lint and build, I'm hoping the acceptance jobs start first, so that this doesn't add to the bottom-line wall-clock time... even still, may want to cache pip, etc.

The existing pip check in the acceptance job is still good to keep, as we want to know if our test dependencies have drifted or conflict with each other.

Ideally we'd just install the jupyterlab-lsp tarball, to ensure the install_requires is configured properly, but I don't know how to make pip do that and not pull in old versions of a locally-built dependency.

User-facing changes

N/A, but should help non-dev installs go more smoothly.

Backwards-incompatible changes

N/A

Chores

  • linted
  • tested
  • documented
  • changelog entry

@bollwyvl
Copy link
Collaborator Author

bollwyvl commented Jan 6, 2021

Ok, all the smoke tests are green, will re-target

@bollwyvl bollwyvl changed the base branch from master to jupyterlab3 January 6, 2021 13:43
@bollwyvl bollwyvl changed the title [wip] Add pip-only install/CLI smoke test Add pip-only install/CLI smoke test Jan 6, 2021
@bollwyvl bollwyvl mentioned this pull request Jan 6, 2021
10 tasks
@krassowski krassowski merged commit 5f259fe into jupyter-lsp:jupyterlab3 Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants