Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datacenter attribute for nomad, fix data_with_permissions #235

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

nicholasjackson
Copy link
Contributor

@nicholasjackson nicholasjackson commented Aug 24, 2023

Fixes #234

strInt := fmt.Sprintf("0%d", permissions)
oInt, _ := strconv.ParseInt(strInt, 8, 64)

perms := os.FileMode(oInt)

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types

Incorrect conversion of a 64-bit integer from [strconv.ParseInt](1) to a lower bit size type uint32 without an upper bound check.
@nicholasjackson nicholasjackson merged commit 3570895 into main Aug 25, 2023
@eveld eveld deleted the b-nomad-dc branch October 31, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nomad cluster creation fails if datacenter is not dc1
1 participant