A few features #43
Open
A few features #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like Gson's `Expose` but inversed.
The `AnnotationInspectorTest` works by counting how many `@Deprecated` the `AnnotationInspector` will find on a test class. This does not work anymore because in Java 9, the method `Object.finalize()` gets deprecated as well. While there is the possibility to if/else around this using class header magic, this will bite us again when reflective access to `Object` will be forbidden. Instead, I simply replaced `@Deprecated` with `@ExposeMethodResult`.
Again, not tested yet
|
@piegamesde thanks a lot for your contribution. Something happened with my github settings and I stopped getting notifications for this project altogether, so I apologize for the delay. I like the ideas you submitted and will do some minor changes over the holidays, then merge. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excludeannotation to exclude single fieldsLet me know what you think of each of these (I just didn't want to make a separate PR for each tiny commit). They are all untested yet, I'll polish them later on if the general idea gets approved.