feat: Ability to scan both normal codes and inverted codes #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafaRuiz
changed the title
navaronbracke
requested changes
Oct 14, 2024
android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScanner.kt
Outdated
Show resolved
Hide resolved
ios/Classes/MobileScanner.swift
Outdated
|
|
||
| func invertImage(image: UIImage) -> UIImage { | ||
| let ciImage = CIImage(image: image) | ||
| let filter = CIFilter(name: "CIColorInvert") |
There was a problem hiding this comment.
I would not use a magic string here, you should be using https://developer.apple.com/documentation/coreimage/cifilter/3228292-colorinvert
There was a problem hiding this comment.
@navaronbracke can you give me a hand here?
I'm trying to make it API available, as I've seen there are a few statements for iOS 13 somewhere in the project, but despite setting my project deployment target to 15, I keep seeing this:
I've done just a little Swift in my life, it's been more Android
Co-authored-by: Navaron Bracke <[email protected]>
Co-authored-by: Navaron Bracke <[email protected]>
…canner.kt Co-authored-by: Navaron Bracke <[email protected]>
Co-authored-by: Navaron Bracke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started on #1214 to improve #1071 but with a few enhancements:
intervalInvertImageinstead of choosing whether to invert the image constantly or not. This way we can read both types, for example:Both types of codes (example)