fix: handle errors in onDetect; exclude armv7 for iOS #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navaronbracke
commented
Oct 11, 2024
| target.build_configurations.each do |config| | ||
| config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '15.5.0' | ||
| end | ||
| target.build_configurations.each do |config| |
There was a problem hiding this comment.
This was badly indented
navaronbracke
commented
Oct 11, 2024
| # Flutter.framework does not contain a i386 slice, and MLKit does not support armv7. | ||
| s.pod_target_xcconfig = { | ||
| 'DEFINES_MODULE' => 'YES', | ||
| 'EXCLUDED_ARCHS[sdk=iphonesimulator*]' => 'i386 armv7', |
There was a problem hiding this comment.
I added armv7 for both devices & simulators, per the MLKit docs. This should fix the reported build issue with IPA's.
navaronbracke
commented
Oct 11, 2024
| _subscription = controller.barcodes.listen(widget.onDetect); | ||
| _subscription = controller.barcodes.listen( | ||
| widget.onDetect, | ||
| onError: widget.onDetectError, |
There was a problem hiding this comment.
We were not handling errors from the stream when using on detect.
navaronbracke
commented
Oct 11, 2024
| @@ -34,15 +35,17 @@ class MobileScanner extends StatefulWidget { | |||
| final MobileScannerController? controller; | |||
|
|
|||
| /// The function that signals when new codes were detected by the [controller]. | |||
| /// If null, use the controller.barcodes stream directly to capture barcodes. | |||
There was a problem hiding this comment.
This guidance is obsolete, as we now can handle errors in the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1209
Fixes #1210