fix(failure using ipv6 in tests): fix controller addresses resolution #649
Conversation
SimoneDutto
force-pushed
the
failure-using-ipv6
branch
3 times, most recently
from
6c1ed28 to
208a476
Compare
There was a problem hiding this comment.
A good start, the docs do need updating.
This change though has no impact on how the actual tests are run in the GitHub jobs. Update the workflow files as well as https://github.com/juju/terraform-provider-juju/wiki/Developing.
… in makefile to enable ipv6 The previuos shell command to extract the ipv6 from the show-controller was removing the '[' from the ipv6. The new command removed only the surrounding '[', making it possible to work with ipv6 fix juju#582
SimoneDutto
force-pushed
the
failure-using-ipv6
branch
from
208a476 to
8f15dda
Compare
the github actions already have the right bash command for ipv6 compatibility. So i think this issue with ipv6 was local because people were using the wrong command from the docs/using the makefile. Or do you have any recent examples of this issue in the ci? |
updated the developer wiki as well. |
Description
The previous shell command to extract the ipv6 removed all the '[' regardless.
The new command removes only the surrounding '[', preserving the
[for the ipv6.Fixes: #582
The shell command was copied from the workflows.
https://github.com/SimoneDutto/terraform-provider-juju/blob/22b76d0d0f67fc22df41a424c0fc0539119320bd/.github/workflows/test_integration.yml#L150
Type of change