fix: jaas integration test #641
Open
+120
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alesstimec
requested review from
hmlanigan and
anvial
and removed request for
hmlanigan
alesstimec
force-pushed
the
jaas-integration-fix
branch
23 times, most recently
from
8b62656 to
00cf851
Compare
alesstimec
force-pushed
the
jaas-integration-fix
branch
from
00cf851 to
54f8588
Compare
hmlanigan
requested changes
Dec 13, 2024
|
The plan is to update the resource documentation for use with JIMM and fix the test to run in both environments. |
alesstimec
force-pushed
the
jaas-integration-fix
branch
9 times, most recently
from
e0c8cf0 to
006a578
Compare
alesstimec
force-pushed
the
jaas-integration-fix
branch
from
006a578 to
ee0178a
Compare
kian99
approved these changes
Dec 17, 2024
| @@ -41,7 +41,7 @@ jobs: | |||
| test: | |||
| name: Integration-JAAS | |||
| needs: build | |||
| runs-on: ubuntu-latest | |||
| runs-on: [self-hosted, jammy, x64] | |||
There was a problem hiding this comment.
Ah I remember I investigated moving to self hosted runners and it didn't work because docker compose wasn't available. I asked about adding it to self-hosted runners and they said they'd add it to their backlog (this was ~3 months ago).
But I see you're already installing it all yourself below which works too.
alesstimec
force-pushed
the
jaas-integration-fix
branch
7 times, most recently
from
8bc9cc4 to
7974ba0
Compare
hmlanigan
reviewed
Dec 18, 2024
hmlanigan
reviewed
Dec 18, 2024
alesstimec
force-pushed
the
jaas-integration-fix
branch
from
7974ba0 to
7ef5c27
Compare
alesstimec
force-pushed
the
jaas-integration-fix
branch
from
7ef5c27 to
ffea34b
Compare
Co-authored-by: Kian Parvin <[email protected]>
alesstimec
force-pushed
the
jaas-integration-fix
branch
from
ffea34b to
d344dfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
juju_kebernetes_cloudresource when applying to JAAS (parent_cloud_namemust be specified)Type of change