Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloud): resolve acceptance test issues by removing model #609

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

anvial
Copy link
Member

@anvial anvial commented Oct 17, 2024

Description

  • Modified resource_kubernetes_cloud_test.go to adjust acceptance tests for Kubernetes cloud, removing the model and ensuring tests run with LXD.

Type of change

  • Change in tests (one or several tests have been changed)

Environment

  • Juju controller version:

  • Terraform version:

QA steps

# pass github actions

@anvial anvial requested a review from hmlanigan October 17, 2024 15:11
@anvial anvial force-pushed the fix-k8slcoud-acctest-by-dropping-model branch 2 times, most recently from 04ce816 to df3c675 Compare October 17, 2024 15:20
- Modified `resource_kubernetes_cloud_test.go` to adjust acceptance tests for Kubernetes cloud,
  removing the model and ensuring tests run with LXD.
@anvial anvial force-pushed the fix-k8slcoud-acctest-by-dropping-model branch from df3c675 to f1668fd Compare October 17, 2024 15:22
Copy link
Member

@hmlanigan hmlanigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@anvial anvial merged commit ae8b121 into juju:main Oct 17, 2024
26 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants