Improve jujudata to find controller name by endpoint #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cderici
added
hint/2.9
|
/merge |
This was referenced Oct 17, 2023
cderici
removed
the
area/forward-port
jujubot
added a commit
that referenced
this pull request
Oct 20, 2023
#966 #### Description This is a forward port for the fix #964 for the issue #771 that was on 2.9, bringing it into 3.x. #### QA Steps Manual QA should follow the steps described in #771. Find the details of a controller you bootstrapped (any controller would do): ```sh $ juju show-controller --show-password ``` Grab the details there and plug them into either a script or in the repl (repl is awkward to use with the certificate): ```python c = Controller() await c.connect(endpoint="<ip>:17070", username="admin", password="admin_pass", cacert="ca_cert") # explicit connection with credential values # check the name print(c.controller_name) ``` All CI tests need to pass. #### Notes & Discussion JUJU-4781
Merged
jujubot
added a commit
that referenced
this pull request
Oct 26, 2023
#979 ## What's Changed * Deploy by revision on 2.9 by @cderici in #957 * Application refresh with resources by @cderici in #960 * Improve jujudata to find controller name by endpoint by @cderici in #964 * Allow switch kwarg in refresh to switch to local charms by @jack-w-shaw in #968 * Parse charm URLs consistantly for local charms by @jack-w-shaw in #969 * Fix juju config directory location pointed by XDG_DATA_HOME by @cderici in #975 * [JUJU-4779] Switch to local properly by @jack-w-shaw in #977 #### Notes & Discussion JUJU-4850 [JUJU-4779]: https://warthogs.atlassian.net/browse/JUJU-4779?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows all kinds of connections to set the
controller_nameby default by looking up theendpointsin thejujudata.Fixes #771
QA Steps
Manual QA should follow the steps described in #771.
Find the details of a controller you bootstrapped (any controller would do):
Grab the details there and plug them into either a script or in the repl (repl is awkward to use with the certificate):
All CI tests need to pass.
Notes & Discussion
JUJU-4781