Deploy by revision on 2.9 #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by passing the revision info through the ResolveCharm api call. fixes juju#690
This is needed because in libjuju we default to latest/stable if no channel is specified. It is dangerous if we don't add this check because without it the libjuju would deploy the wrong revision without an exception if --revision is used but no --channel is given.
Otherwise fail early without making any additional API calls.
that deploys juju-qa-test --channel 2.0/stable --revision 22
without the --revision parameter this will deploy rev 21, but with the parameter it will deploy 19.
flags are validated before deploying charms or bundles
jack-w-shaw
approved these changes
Oct 11, 2023
examples/deploywithrevision.py
Outdated
There was a problem hiding this comment.
rename to deploy_with_revision.py
|
/merge |
Merged
jujubot
added a commit
that referenced
this pull request
Oct 26, 2023
#979 ## What's Changed * Deploy by revision on 2.9 by @cderici in #957 * Application refresh with resources by @cderici in #960 * Improve jujudata to find controller name by endpoint by @cderici in #964 * Allow switch kwarg in refresh to switch to local charms by @jack-w-shaw in #968 * Parse charm URLs consistantly for local charms by @jack-w-shaw in #969 * Fix juju config directory location pointed by XDG_DATA_HOME by @cderici in #975 * [JUJU-4779] Switch to local properly by @jack-w-shaw in #977 #### Notes & Discussion JUJU-4850 [JUJU-4779]: https://warthogs.atlassian.net/browse/JUJU-4779?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This backports the support for deploy by revision from master branch (3.x track) (#830) onto the 2.9 track.
QA Steps
So we have 1 example and 2 integration tests for this, all of them should work well (I tested it against 2.9.45 on lxd).
All the rest of the CI tests need to pass.
Notes & Discussion
JUJU-4716