Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: simplify contributor guide #1202

Merged
merged 2 commits into from
Nov 21, 2024
Merged

chore: simplify contributor guide #1202

merged 2 commits into from
Nov 21, 2024

Conversation

dimaqq
Copy link
Contributor

@dimaqq dimaqq commented Nov 20, 2024

james-garner-canonical
james-garner-canonical approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@james-garner-canonical james-garner-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one small suggestion to link to the commit types we use, since conventionalcommits.org itself doesn't care about the exact types, but python-libjuju's CI certainly does

docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
@dimaqq
Copy link
Contributor Author

dimaqq commented Nov 21, 2024

/merge

@jujubot jujubot merged commit ebf3c0d into juju:main Nov 21, 2024
21 of 22 checks passed
@dimaqq dimaqq deleted the chore-better-contrib-guide branch November 22, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-garner-canonical james-garner-canonical james-garner-canonical approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dimaqq @james-garner-canonical @jujubot