Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: nuke per-facade schema #1194

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

dimaqq
Copy link
Contributor

@dimaqq dimaqq commented Nov 19, 2024

Individual _clientNN.py files don't need the schemata inlined, remove that field from codegen.

Copy link
Contributor

@james-garner-canonical james-garner-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this makes the generated code a lot easier for humans to look at. Hopefully no users have used XFacade.schema though

@dimaqq
Copy link
Contributor Author

dimaqq commented Nov 19, 2024

No matches in super-tox collection of charms or COU 🎉

@dimaqq dimaqq force-pushed the chore-nuke-per-facade-schema branch from 11109f3 to 24b81dc Compare November 19, 2024 07:37
@dimaqq
Copy link
Contributor Author

dimaqq commented Nov 20, 2024

/merge

@dimaqq dimaqq marked this pull request as ready for review November 20, 2024 02:37
@dimaqq dimaqq force-pushed the chore-nuke-per-facade-schema branch from 24b81dc to e9b942b Compare November 20, 2024 04:36
@dimaqq
Copy link
Contributor Author

dimaqq commented Nov 20, 2024

/merge

@jujubot jujubot merged commit 651e36a into juju:main Nov 20, 2024
21 of 22 checks passed
@dimaqq dimaqq deleted the chore-nuke-per-facade-schema branch November 22, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants