Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ruff up the codebase #1186

Merged
merged 34 commits into from
Nov 18, 2024
Merged

chore: ruff up the codebase #1186

merged 34 commits into from
Nov 18, 2024

Conversation

dimaqq
Copy link
Contributor

@dimaqq dimaqq commented Nov 12, 2024

What this PR does

In short, we'll be relying on ruff via pre-commit as opposed to flake8 via tox.

  • switches from flake8 to ruff
  • reformats the source code
  • reformats the docstrings where safe, conservatively
  • resolves ruff complaints where that's straightforward
  • silences with a FIXME where public API could break or code change is not obvious or where too much manual work is required, those can be fixed in separate PRs
  • updates the CI and docs for the above

Check list

  • pre-commit config
  • ruff over the codebase
  • resolve or silence errors
  • kill old linter and github actions
  • GitHub actions to check pre-commit
  • run pre-commit after codegen
  • add to docs

@dimaqq dimaqq marked this pull request as ready for review November 13, 2024 08:50
@dimaqq
Copy link
Contributor Author

dimaqq commented Nov 14, 2024

I've reviewed the full diff on github.

Copy link
Contributor

@james-garner-canonical james-garner-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through this with Dima in a video call, and I think we're good to land this now

@dimaqq
Copy link
Contributor Author

dimaqq commented Nov 18, 2024

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants